----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121940/ -----------------------------------------------------------
(Updated Jan. 10, 2015, 2:03 p.m.) Review request for Marble, Bernhard Beschow, Mihail Ivchenko, Dennis Nienhüser, and Torsten Rahn. Repository: marble Description ------- This patch adds "View Properties" feature to newly introduced right mouse click menu on placemarks from `FileView` panel, by reusing `EditTextAnnotationDialog`. This also introduces read-only mode for `EditTextAnnotationDialog`, so placemark data won't get changed anyway. Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5849514216783872 Diffs ----- src/lib/marble/EditTextAnnotationDialog.cpp 2caa13a src/lib/marble/FileViewWidget.h bd44e6d src/lib/marble/EditTextAnnotationDialog.h 4d812f1 src/lib/marble/FileViewWidget.cpp e0de340 src/lib/marble/PlacemarkEditHeader.h 77c8259 src/lib/marble/PlacemarkEditHeader.cpp 9ca61b3 Diff: https://git.reviewboard.kde.org/r/121940/diff/ Testing ------- Right File Attachments ---------------- Context menu https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/99981361-1188-4aa7-a874-47d6c4c72757__Screen_Shot_2015-01-09_at_8.36.13_PM.png Placemark View https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/0d44034e-f796-46e3-b2b4-0d63570ea3c8__Screen_Shot_2015-01-09_at_8.36.26_PM.png Thanks, Illya Kovalevskyy
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
