----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121934/ -----------------------------------------------------------
(Updated Jan. 10, 2015, 9:41 p.m.) Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn. Summary (updated) ----------------- Replacing EARTH_RADIUS in projection classes Repository: marble Description (updated) ------- This patch does get rid of `EARTH_RADIUS` from projection classes, by storing current planet radius in ViewportParams. Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5895892615823360 Diffs ----- src/lib/marble/MarbleMap.h 260d46b src/lib/marble/MarbleMap.cpp 13becfc src/lib/marble/MarbleModel.h f13491e src/lib/marble/MarbleModel.cpp 04605c6 src/lib/marble/ViewportParams.h 09aeecb src/lib/marble/ViewportParams.cpp bca8ea9 src/lib/marble/projections/SphericalProjection.cpp c11300b src/lib/marble/projections/VerticalPerspectiveProjection.cpp 806e028 Diff: https://git.reviewboard.kde.org/r/121934/diff/ Testing (updated) ------- Visual testing, see screenshots. File Attachments (updated) ---------------- Current state https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/dd2f60ea-4e88-4a3b-9b19-c2573ddcd7a2__Screen_Shot_2015-01-10_at_9.16.55_PM.png With patch applied https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/e621fa5e-8b84-48fc-87e5-3afc9f7ac36f__Screen_Shot_2015-01-10_at_9.39.34_PM.png Thanks, Illya Kovalevskyy
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
