----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122426/ -----------------------------------------------------------
(Updated Feb. 4, 2015, 4:12 p.m.) Review request for Marble. Repository: marble Description ------- Marble: visual glitches on mouse events Diffs ----- src/lib/marble/MarbleInputHandler.cpp 0fe322c src/lib/marble/kineticmodel.h 731d124 src/lib/marble/kineticmodel.cpp b246781 Diff: https://git.reviewboard.kde.org/r/122426/diff/ Testing ------- Bug#1: When double-clicking and the mouse cursor is not above the map, zoom-in triggers and this came as very annoying while trying to pan the globe without dragging. -coding: -addded an if statement which tests whether the mouse is/isn't above the map. Bug#2: While the globe is spinning (after a mouse drag), using pan with arrows causes a visual glitch: the globe jumps to a position for a fraction of a second but it continues its spin. -coding: -added a bool function to KineticModel which retruns whether the globe is spinning or not (checking its velocity). this helped me further on. -added an extra condition which ensures that panning with arrows triggers only when the globe's velocity is null. Thanks, Constantin Mihalache
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
