----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122718/#review76586 -----------------------------------------------------------
It works, but there are a few problems with the changes you have made. src/plugins/render/annotate/AnnotatePlugin.cpp <https://git.reviewboard.kde.org/r/122718/#comment52752> Please follow the coding style from above. You need to leave a space after each keyword (such as if/switch/while/for) as well as after the open paranthesis and before the closing one. Also, please **DO NOT** use tabs. If you're using tabs, convert them into spaces before submiting a patch. In your IDE with 8 spaces per tab this probably looks good, but on my machine (with 4 spaces per tab), it doesn't. This could be avoided by using spaces. src/plugins/render/annotate/AnnotatePlugin.cpp <https://git.reviewboard.kde.org/r/122718/#comment52754> Here is also something wrong. Take a look at the "Escape" implementation. You need to **return true** here, because, otherwise, the evenFilter will return false and the event will propagate to underlaying layers. But we have just caught the event. - Calin Cruceru On Feb. 25, 2015, 11:05 a.m., Rares Visalom wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122718/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 11:05 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > I added the option in the event filter function of the annotate plugin. > > > Diffs > ----- > > src/plugins/render/annotate/AnnotatePlugin.cpp faefeda > > Diff: https://git.reviewboard.kde.org/r/122718/diff/ > > > Testing > ------- > > > Thanks, > > Rares Visalom > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
