> On March 1, 2015, 7:22 p.m., Dennis Nienhüser wrote: > > src/lib/marble/TourWidget.cpp, line 442 > > <https://git.reviewboard.kde.org/r/122728/diff/1/?file=351852#file351852line442> > > > > In which case is the current index not valid? If this should not happen > > really, I'd rather do nothing in that case.
A valid index belongs to a model and has a positive row and column. Shortly: if there is a selected item the new primitive will be inserted after it, so the list would scroll there. else, the primitive will be inserted at the end of the list, so the list would scroll to bottom. - Marius ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122728/#review76828 ----------------------------------------------------------- On Feb. 26, 2015, 12:38 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122728/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 12:38 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Bug 1: When editing an already exisiting "Wait x seconds" item, the wrong > icon is displayed( the sound cue one ) > > Bug 2: Added an autoscroll to the item list. Now when you add a new item, the > list will scroll to it, making it easier to track newly added items. ( This > behaviour is usefull when dealing with many items ) > > > Diffs > ----- > > src/lib/marble/TourWidget.cpp 6bce39d > src/lib/marble/WaitEditWidget.cpp 70f8acf > > Diff: https://git.reviewboard.kde.org/r/122728/diff/ > > > Testing > ------- > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
