----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122747/#review76902 -----------------------------------------------------------
src/lib/marble/TourItemDelegate.cpp <https://git.reviewboard.kde.org/r/122747/#comment52902> Where does this color come from? :-) Could you use a color from the application's QPalette instead? See the code in line 53-55 for inspiration ...) src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/122747/#comment52903> This method name is a bit ambiguous since it could also sound as if it returned the highlightItem. Maybe something like selectHighlightItem(index) or applyHighlightItem or setHighlightItem ? src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/122747/#comment52905> we usually prefer pre-increment instead of post-increment ... src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/122747/#comment52904> does the documentation really suggest to use repaint() instead of update() ? Usually it's discouraged to call repaint() directly .. - Torsten Rahn On März 2, 2015, 1:27 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122747/ > ----------------------------------------------------------- > > (Updated März 2, 2015, 1:27 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > The tour widget lacked real time highlighting to items currently played while > previewing a movie. > > > Diffs > ----- > > src/lib/marble/SerialTrack.h 3146d7f > src/lib/marble/SerialTrack.cpp 667b85f > src/lib/marble/TourItemDelegate.cpp 9eb0b66 > src/lib/marble/TourPlayback.h 4c6d64d > src/lib/marble/TourPlayback.cpp 07f4cdb > src/lib/marble/TourWidget.h 0e0c3f6 > src/lib/marble/TourWidget.cpp 6bce39d > > Diff: https://git.reviewboard.kde.org/r/122747/diff/ > > > Testing > ------- > > works on master branch @ 20 feb. > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
