----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122853/#review77231 -----------------------------------------------------------
Ship it! Ship It! - Dennis Nienhüser On March 8, 2015, 7:47 a.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122853/ > ----------------------------------------------------------- > > (Updated March 8, 2015, 7:47 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > If we pass unknown planet name to PlanetFactory, it must show warning > > and set planet name to 'Unknown'. See commit 61e92c8ff13a26565 for > > proper behavior. > > Issue detected by Cppcheck: "Expression is always false because 'else > > if' condition matches previous condition at line 80." > > > Diffs > ----- > > src/lib/marble/PlanetFactory.cpp 9c4b1d2 > > Diff: https://git.reviewboard.kde.org/r/122853/diff/ > > > Testing > ------- > > > Thanks, > > Boris Egorov > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
