----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122849/#review77285 -----------------------------------------------------------
Ship it! Ship It! src/lib/marble/VisiblePlacemark.cpp <https://git.reviewboard.kde.org/r/122849/#comment53076> Good question - maybe make it a constant in the header file? - Torsten Rahn On März 7, 2015, 11:37 vorm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122849/ > ----------------------------------------------------------- > > (Updated März 7, 2015, 11:37 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > The feature was disabled(greyed out) and it didn't work. Now drawing the > placemark keeps account of the scale member. > > I have one issue though: > I didn't really know where to place a constant for a maximum icon size( > limiting the user ) so I could use your opinion. > > > Diffs > ----- > > src/lib/marble/EditPlacemarkDialog.ui 2d09c6e > src/lib/marble/PlacemarkLayout.cpp 6c0af30 > src/lib/marble/VisiblePlacemark.cpp d57dcb0 > > Diff: https://git.reviewboard.kde.org/r/122849/diff/ > > > Testing > ------- > > works for me. > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
