----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122938/#review77813 -----------------------------------------------------------
Looks great! Solve the following issues and you can then start working on implementing this on Polylines as well. @Torsten what do you think? This was one of the tasks you proposed. src/plugins/render/annotate/EditPolygonDialog.h (line 17) <https://git.reviewboard.kde.org/r/122938/#comment53378> Please move the include directives which are not needed in the header file, in the .cpp file. src/plugins/render/annotate/EditPolygonDialog.cpp (line 128) <https://git.reviewboard.kde.org/r/122938/#comment53379> Where is it deleted? As you can see here http://qt-project.org/doc/qt-4.8-snapshot/qabstractitemview.html#setItemDelegate, the view does not take ownership of the delegate. src/plugins/render/annotate/NodeItemDelegate.h (line 20) <https://git.reviewboard.kde.org/r/122938/#comment53380> <QItemDelegate> should be #include'ed here. We want to avoid such situations when the inclusion of a header file (this one) depends on previous inclusions (depends on the inclusion of <QItemDelegate> - see the previous issue). src/plugins/render/annotate/NodeItemDelegate.cpp (line 24) <https://git.reviewboard.kde.org/r/122938/#comment53381> Use Q_UNUSED. Same for the code from below. - Calin Cruceru On March 14, 2015, 2:09 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122938/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 2:09 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > In order to do this, i used the already availible widget LatLonEdit and set > it as the model's edit wdiget, via a new delegate class. > > This allows real-time modification of the nodes with the LatLonEdit's high > precision. ( Even though dragging the nodes was possible, it wasn't really > precise, and it did not allow exact coordinates input ( keyboard input ). > > > Diffs > ----- > > src/plugins/render/annotate/CMakeLists.txt 594ea89 > src/plugins/render/annotate/EditPolygonDialog.h 6f07648 > src/plugins/render/annotate/EditPolygonDialog.cpp 8c8b302 > src/plugins/render/annotate/EditPolygonDialog.ui c4f11f3 > src/plugins/render/annotate/NodeItemDelegate.h PRE-CREATION > src/plugins/render/annotate/NodeItemDelegate.cpp PRE-CREATION > src/plugins/render/annotate/NodeModel.h 4586eea > src/plugins/render/annotate/NodeModel.cpp 984a2be > > Diff: https://git.reviewboard.kde.org/r/122938/diff/ > > > Testing > ------- > > Works for me. > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
