----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123053/ -----------------------------------------------------------
(Updated March 20, 2015, 5:15 p.m.) Review request for Marble and Calin Cruceru. Changes ------- removed redundant signal from first aproach. Repository: marble Description ------- Bugs: #1 In EditPolylineDialog, modifying the width spinbox didn't update the polyline on the globe. *I am not sure if my aproach is the best one, but i couldn't see another way of doing it: the spinbox's signal requires a slot with a 'double' parameter, and the one that updates the polyline doesn't take any. #2 In EditGroundOverlayDialog, pressing 'cancel' creates an overlay frame. Diffs (updated) ----- src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac src/plugins/render/annotate/EditPolylineDialog.h 4d383b8 src/plugins/render/annotate/EditPolylineDialog.cpp a99a3e9 Diff: https://git.reviewboard.kde.org/r/123053/diff/ Testing ------- It solved the mentioned issues. Thanks, Constantin Mihalache
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
