-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123036/#review78106
-----------------------------------------------------------



src/plugins/render/annotate/AnnotatePlugin.cpp (line 1071)
<https://git.reviewboard.kde.org/r/123036/#comment53516>

    In Qt coding style we don't test against 0x0. We just test for m_focusItem 
:-)
    
    Great fix otherwise :)


- Torsten Rahn


On März 18, 2015, 6:24 nachm., hardik  beladiya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123036/
> -----------------------------------------------------------
> 
> (Updated März 18, 2015, 6:24 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Bugs: 342777
>     http://bugs.kde.org/show_bug.cgi?id=342777
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I add condition that if it has focus then after we enable remove action
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac 
> 
> Diff: https://git.reviewboard.kde.org/r/123036/diff/
> 
> 
> Testing
> -------
> 
> Tested and does not crash because we disable the remove action if it has not 
> focus :-)
> 
> 
> Thanks,
> 
> hardik  beladiya
> 
>

_______________________________________________
Marble-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/marble-devel

Reply via email to