> On March 30, 2015, 1:59 p.m., Dennis Nienhüser wrote: > > src/lib/marble/PlacemarkLayout.cpp, line 57 > > <https://git.reviewboard.kde.org/r/123181/diff/1/?file=359472#file359472line57> > > > > and `return true;` here and spare the isRoom boolean?
Indeed that's strictly better - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123181/#review78214 ----------------------------------------------------------- On March 31, 2015, 7:20 a.m., Adam Dabrowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123181/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 7:20 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > -Added Right position for placemark labels. Up to 7 positions are available > for labels if placemarks overlap. > -Added sorting of placemarks before layouting. Without this there would be > labels "jumping" around as several moving placemarks overlap (now they are > drawn in the same order and there is no jumping). Cost of sorting is > miniscule compared to other operations performed when layouting. > -Refactored code for checking if layout space is already occupied > > > Diffs > ----- > > src/lib/marble/PlacemarkLayout.cpp 6c0af30 > src/lib/marble/geodata/data/GeoDataLabelStyle.h 046f7bc > src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 5949c7d > > Diff: https://git.reviewboard.kde.org/r/123181/diff/ > > > Testing > ------- > > Displayed 1, 2, 3 and 7+ items. > Checked for no flickering. > > > Thanks, > > Adam Dabrowski > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
