----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123193/#review78286 -----------------------------------------------------------
Ship it! Ship It! - Dennis Nienhüser On März 31, 2015, 8:37 vorm., Adam Dabrowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123193/ > ----------------------------------------------------------- > > (Updated März 31, 2015, 8:37 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > While in common use the CMAKE_INSTALL_PREFIX will be something like > /usr/local, I had the need to fix this as we are deploying marble on embedded > system in a highly customized way. > The new version is strictly better as it works the same with non-empty > prefixes but it also works with empty prefix. > > Note that this might apply to other instances of where "STRING(LENGTH ..." is > used > > > Diffs > ----- > > src/CMakeLists.txt 6c4cc7f > > Diff: https://git.reviewboard.kde.org/r/123193/diff/ > > > Testing > ------- > > I've been building with this cmake since three months or so, both with empty > and /usr/local prefixes. > > > Thanks, > > Adam Dabrowski > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
