----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123202/#review78328 -----------------------------------------------------------
src/lib/marble/layers/TextureLayer.h (line 66) <https://git.reviewboard.kde.org/r/123202/#comment53627> Given the `GeoSceneTextureTile*` parameter in `addTextureLayer` this looks a bit strange, I'd rather expect another `GeoSceneTextureTile*` parameter instead of a QString. Alternatively have `addTextureLayer` return a QString as the key which should be passed to `removeTextureLayer`? src/lib/marble/layers/TextureLayer.cpp (line 258) <https://git.reviewboard.kde.org/r/123202/#comment53625> redundant. The whole block could also be replaced by `qDeleteAll( d->m_customTextures );` src/lib/marble/layers/TextureLayer.cpp (line 571) <https://git.reviewboard.kde.org/r/123202/#comment53626> redundant - Dennis Nienhüser On April 1, 2015, 6:41 a.m., Adam Dabrowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123202/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 6:41 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > TextureLayer class was created based on parsing the .dgml content only. With > this patch, MarbleMap API has been extended to allow a dynamic updates of > texture layer (i.e. from the qml form-like interface, by pointing to a source > directory and reading/inputting some parameters, by pointing to a geotiff and > making tiles on the fly etc.). Theses custom textures are then added to > static texture list and displayed. > > > Diffs > ----- > > src/lib/marble/MarbleMap.h 260d46b > src/lib/marble/MarbleMap.cpp 13becfc > src/lib/marble/layers/TextureLayer.h fed6167 > src/lib/marble/layers/TextureLayer.cpp 9d8976f > > Diff: https://git.reviewboard.kde.org/r/123202/diff/ > > > Testing > ------- > > Works well on my machine, tested by using for about 3-4 months now. Tested > with 1, 2 and 3 dynamic texture layers (based on aerial photos). > > > Thanks, > > Adam Dabrowski > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
