----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123122/#review78376 -----------------------------------------------------------
Sorry, still found a few minor issues. Should be ready for submission afterwards. src/lib/marble/FormattedTextWidget.h (line 29) <https://git.reviewboard.kde.org/r/123122/#comment53644> "explicit" keyword missing :) src/lib/marble/FormattedTextWidget.h (line 33) <https://git.reviewboard.kde.org/r/123122/#comment53645> This should be QString text() const The "get" prefix is only used for static methods in Qt APIs src/lib/marble/FormattedTextWidget.cpp (line 104) <https://git.reviewboard.kde.org/r/123122/#comment53643> I guess this should be QString text() const - Torsten Rahn On März 29, 2015, 9:42 vorm., Constantin Mihalache wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123122/ > ----------------------------------------------------------- > > (Updated März 29, 2015, 9:42 vorm.) > > > Review request for Marble, Calin Cruceru and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > #1 Widget implementation: > I've respected the structured given by EditPlacemarkDialog, which had > formatted description. > I've first added this functionality to Polygon, Polyline and GroundOverlay > editing. > I've also replaced the code in EditPlacemarkDialog with the widget. > #2 Solved a visual bug in EditPolygonDialog and EditPolylineDialog: > The node table header didn't stretch with the window. > > > Diffs > ----- > > src/lib/marble/CMakeLists.txt 6c65015 > src/lib/marble/EditPlacemarkDialog.h 015173c > src/lib/marble/EditPlacemarkDialog.cpp 3d0d61f > src/lib/marble/EditPlacemarkDialog.ui e17bf14 > src/lib/marble/FormattedTextWidget.h PRE-CREATION > src/lib/marble/FormattedTextWidget.cpp PRE-CREATION > src/lib/marble/FormattedTextWidget.ui PRE-CREATION > src/plugins/render/annotate/EditGroundOverlayDialog.cpp df7d6d2 > src/plugins/render/annotate/EditGroundOverlayDialog.ui 1151b35 > src/plugins/render/annotate/EditPolygonDialog.cpp c647e6b > src/plugins/render/annotate/EditPolygonDialog.ui 563ca2d > src/plugins/render/annotate/EditPolylineDialog.cpp a99a3e9 > src/plugins/render/annotate/EditPolylineDialog.ui 3421a72 > > Diff: https://git.reviewboard.kde.org/r/123122/diff/ > > > Testing > ------- > > It works. > > > Thanks, > > Constantin Mihalache > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
