----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123221/#review78419 -----------------------------------------------------------
src/plugins/render/annotate/EditPolygonDialog.cpp (line 99) <https://git.reviewboard.kde.org/r/123221/#comment53656> hm, why not connect it to updatePolygon() directly? You can connect slots with a certain parameter to one which loses that parameter (you just can not connect it to one with an additional parameter). - Torsten Rahn On April 2, 2015, 10:39 vorm., Constantin Mihalache wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123221/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 10:39 vorm.) > > > Review request for Marble, Calin Cruceru and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > Bugs: > > #1 In EditPolylineDialog, modifying the width spinbox didn't update the > polyline on the globe. > > #2 In EditPolygonDialog, modifying the width spinbox didn't update the > polyline on the globe. > > > Diffs > ----- > > src/plugins/render/annotate/EditPolygonDialog.h 0dbb089 > src/plugins/render/annotate/EditPolygonDialog.cpp 84e5697 > src/plugins/render/annotate/EditPolylineDialog.h 4d383b8 > src/plugins/render/annotate/EditPolylineDialog.cpp a06d55d > > Diff: https://git.reviewboard.kde.org/r/123221/diff/ > > > Testing > ------- > > It works for me. > > > Thanks, > > Constantin Mihalache > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
