> On April 6, 2015, 5:43 vorm., Torsten Rahn wrote: > > Works nicely apart from the m_editStatusChangedNeeded oversight! :-) > > > > I guess the next task would be to fix the case where the lower boundary has > > a higher value than the upper one (and hence the groundoverlay is not > > rendered). I think this should be fixed by ensuring proper values inside > > the dragging functionality as well as the preset setting (if the globe is > > turned upside down - you can determine whether the globe is turned upside > > down by checking the value of the ViewportParams' polarity property). > > In addition it might make sense to also allow rendering GroundOverlays of > > KML files where the bottom value is higher than the top one. But still in > > the first place we should create "proper" KML ourselves.
The suggested task should of course be a separate patch :) - Torsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123259/#review78546 ----------------------------------------------------------- On April 5, 2015, 9:17 nachm., Dávid Kolozsvári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123259/ > ----------------------------------------------------------- > > (Updated April 5, 2015, 9:17 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Until now it wasn't possible to rotate the GroundOverlayFrame manually, only > from it's properties menu, setting the angle in a spinbox. > This patch introduces a user-friendly manual rotation in edit mode, as well > as new icons(thanks to Torsten Rahn) which are shown as handles around it's > edges and corners. > Also, a bug was fixed in this patch: the GroundOverlayFrame wasn't able to > capture the mouse events that occured outside of it's regions while a > controlpoint(handle) was grabbed. > > > Diffs > ----- > > data/CMakeLists.txt 7b96438 > data/bitmaps/editarrows/arrow-diagonal-topleft-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-diagonal-topleft.png PRE-CREATION > data/bitmaps/editarrows/arrow-diagonal-topright-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-diagonal-topright.png PRE-CREATION > data/bitmaps/editarrows/arrow-horizontal-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-horizontal.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-bottomleft-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-bottomleft.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-bottomright-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-bottomright.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-topleft-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-topleft.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-topright-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-rotation-topright.png PRE-CREATION > data/bitmaps/editarrows/arrow-vertical-active.png PRE-CREATION > data/bitmaps/editarrows/arrow-vertical.png PRE-CREATION > src/plugins/render/annotate/AnnotatePlugin.cpp 45e8746 > src/plugins/render/annotate/GroundOverlayFrame.h 194ade5 > src/plugins/render/annotate/GroundOverlayFrame.cpp c27eabd > src/plugins/render/annotate/SceneGraphicsItem.h c59340e > > Diff: https://git.reviewboard.kde.org/r/123259/diff/ > > > Testing > ------- > > Testing was done by me and it works fine. > > > Thanks, > > Dávid Kolozsvári > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
