----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123462/#review79745 -----------------------------------------------------------
src/apps/marble-qt/QtMainWindow.cpp (line 383) <https://git.reviewboard.kde.org/r/123462/#comment54601> Technically fine, but still cumbersome. Please use a local variable or add a new member variable for the action instead of overwriting the whatsthisone. src/apps/marble-qt/QtMainWindow.cpp (line 970) <https://git.reviewboard.kde.org/r/123462/#comment54597> Please use curly brackets also for one liners and include the url in the qdebug output. - Dennis Nienhüser On April 22, 2015, 6:28 vorm., Ana Badescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123462/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 6:28 vorm.) > > > Review request for Marble and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > Displays link under Help menu that attempts to open up the Marble forum in a > browser. > > > Diffs > ----- > > src/apps/marble-qt/QtMainWindow.h 595ffd2 > src/apps/marble-qt/QtMainWindow.cpp c4280c6 > > Diff: https://git.reviewboard.kde.org/r/123462/diff/ > > > Testing > ------- > > > Thanks, > > Ana Badescu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
