----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123406/ -----------------------------------------------------------
(Updated May 2, 2015, 3:44 p.m.) Review request for Marble. Changes ------- Moved the refactoring part of this patch to https://git.reviewboard.kde.org/r/123594/ Repository: marble Description (updated) ------- DEPENDECY: https://git.reviewboard.kde.org/r/123594/ -- Refactoring some classes. This patch needs those classes. so be sure to apply 123594 patch first, then 123406. Firstly: - GeoDataMapChange is introduced, as a tour primitive. It adds the possibility to schedule a map theme or projection change from within the Tour Widget Playlist. - MapChangeEditDialog makes editing possible for the GeoDataMapChange elements. It uses the same UI from the MapViewWidget. - KmlMapChangeTagWriter/Handler + KmlThemeTagHandler + KmlProjectionTagHandler make import/export possible this way: Example kmlFile: <mx:MapChange> <mx:theme>earth/citylights/citylights.dgml</mx:theme> <mx:projection>Spherical</mx:projection> </mx:MapChange> This, after parsing, represents a mapChange element that will change the current map theme to earth/citylights/citylights.dgml and projection to Spherical (Globe) - As it can be seen above, a new xml namespace was introduced (mx), because the new element is Marble only. - Adds a new icon for the mapChange item. ( mapChange.png ) Diffs (updated) ----- data/bitmaps/map-change.png PRE-CREATION src/lib/marble/CMakeLists.txt f448f84 src/lib/marble/MapChangeEditDialog.h PRE-CREATION src/lib/marble/MapChangeEditDialog.cpp PRE-CREATION src/lib/marble/MapChangeTrack.h PRE-CREATION src/lib/marble/MapChangeTrack.cpp PRE-CREATION src/lib/marble/TourItemDelegate.h d0d67d3 src/lib/marble/TourItemDelegate.cpp b038a7f src/lib/marble/TourPlayback.cpp f9bf828 src/lib/marble/TourWidget.h a6cb8ca src/lib/marble/TourWidget.cpp b9fab0e src/lib/marble/geodata/CMakeLists.txt fe22e24 src/lib/marble/geodata/data/GeoDataMapChange.h PRE-CREATION src/lib/marble/geodata/data/GeoDataMapChange.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h f2c062c src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp ea53d43 src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.cpp PRE-CREATION src/lib/marble/geodata/parser/GeoDataParser.cpp 588b086 src/lib/marble/geodata/parser/GeoDataTypes.h 45d81d3 src/lib/marble/geodata/parser/GeoDataTypes.cpp 47fde69 src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.h PRE-CREATION src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.cpp PRE-CREATION src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h d01fd7b src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp 131e3ab src/lib/marble/geodata/writers/kml/KmlTagWriter.cpp 47ca42c src/lib/marble/libmarble.qrc f30e887 Diff: https://git.reviewboard.kde.org/r/123406/diff/ Testing ------- I've tested the feature as much as I could and it worked. If you find any bugs, please report an issue. Thanks, Marius Stanciu
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
