----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123594/#review80147 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On Mai 2, 2015, 3:38 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123594/ > ----------------------------------------------------------- > > (Updated Mai 2, 2015, 3:38 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Separated the refactoring part of the Map Change patch posted earlier. ( to > improve clarity and patch size ) > > This patch refactors the MapViewItemDelegate and CelestialSortFilterProxy > classes from MapViewWidget.cpp to > extend their use in the MapChangeEditDialog ( > https://git.reviewboard.kde.org/r/123406/ ) > > > Diffs > ----- > > src/lib/marble/CMakeLists.txt f448f84 > src/lib/marble/CelestialSortFilterProxyModel.h PRE-CREATION > src/lib/marble/CelestialSortFilterProxyModel.cpp PRE-CREATION > src/lib/marble/MapViewItemDelegate.h PRE-CREATION > src/lib/marble/MapViewItemDelegate.cpp PRE-CREATION > src/lib/marble/MapViewWidget.cpp 4d8f9f6 > > Diff: https://git.reviewboard.kde.org/r/123594/diff/ > > > Testing > ------- > > This does no real modification to Marble. Considered compiling it succesfully > to be enough of a test. > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
