> On May 21, 2015, 7:07 p.m., Dennis Nienhüser wrote: > > Looks fine except some minor stuff noted below. Can you add a unit test as > > well? It's not much work here, all you need to do is to extend one of the > > .kml files in tests/data/ by a couple of label styles. And make sure the > > unit tests still pass of course :) > > The unit test which uses the files in tests/data is > > tests/TestGeoDataWriter.cpp > > Constantin Mihalache wrote: > GeoDataWriter unit test fail at saveAndCompare(). I'm currently working > on it.
**mention:** GeoDataWriter test fails without me extending any existing .kml files. - Constantin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123866/#review80707 ----------------------------------------------------------- On May 22, 2015, 5:24 p.m., Constantin Mihalache wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123866/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 5:24 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Implemented the KmlLabelTagWriter which is useful for writing styles for > TextAnnotations. > > > Diffs > ----- > > src/lib/marble/geodata/CMakeLists.txt fe22e24 > src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.h PRE-CREATION > src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123866/diff/ > > > Testing > ------- > > It works as expected. > > > Thanks, > > Constantin Mihalache > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
