----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124097/#review81492 -----------------------------------------------------------
Nice approach, I like it. src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp (line 51) <https://git.reviewboard.kde.org/r/124097/#comment55858> will crash later when iterating a folder or document. please check the nodeType before a static cast, or cast dynamically and check against 0. src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp (line 84) <https://git.reviewboard.kde.org/r/124097/#comment55859> msvc10 does not understand rang based for loops. please use foreach instead. same below. src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp (line 89) <https://git.reviewboard.kde.org/r/124097/#comment55860> typo src/plugins/runner/osm/translators/OsmFeatureTagTranslator.h (line 34) <https://git.reviewboard.kde.org/r/124097/#comment55861> unsed? src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp (line 44) <https://git.reviewboard.kde.org/r/124097/#comment55862> will also write empty names - intentional? - Dennis Nienhüser On Juni 14, 2015, 8:39 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124097/ > ----------------------------------------------------------- > > (Updated Juni 14, 2015, 8:39 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > These classes are used to translate the GeoDataDocuments into syntactically > correct osm files. > > The OsmDocumentTranslator iterates through all the features within a document > and writes them in the right order. > The OsmPlacemarkTranslator gets all the data necesarry at GeoDataPlacemark > level, and passes it to the static osm writer functions from the last patch. > The OsmFeatureTranslator is an abstract translator, the document and > placemark ones inherit this. > > > Diffs > ----- > > src/plugins/runner/osm/translators/OsmDocumentTagTranslator.h PRE-CREATION > src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp > PRE-CREATION > src/plugins/runner/osm/translators/OsmFeatureTagTranslator.h PRE-CREATION > src/plugins/runner/osm/translators/OsmFeatureTagTranslator.cpp PRE-CREATION > src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.h PRE-CREATION > src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124097/diff/ > > > Testing > ------- > > No testing was done yet as these are just static functions, will taste in > later patches. > Compiles fine > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
