----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124095/#review81495 -----------------------------------------------------------
seems fine (as long as temporary) - Dennis Nienhüser On Juni 14, 2015, 8:26 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124095/ > ----------------------------------------------------------- > > (Updated Juni 14, 2015, 8:26 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > The OsmObjectManager is a temporary solution for managing OSM id ( used to > ref osm tags ). This will be changed as soon as I > find a feasible solution to store osm-specific data in placemarks. > > The OsmObjectAttributeWriters is a convenience class used to write typical > atributes ( more might be added later ) > > The OsmTagTagWriter is a tool used to write tags like <tag k="key" v="value"> > > > Diffs > ----- > > src/plugins/runner/osm/OsmObjectManager.h PRE-CREATION > src/plugins/runner/osm/OsmObjectManager.cpp PRE-CREATION > src/plugins/runner/osm/handlers/OsmElementDictionary.h 44a993c > src/plugins/runner/osm/handlers/OsmElementDictionary.cpp f493e7b > src/plugins/runner/osm/writers/OsmObjectAttributeWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmTagTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124095/diff/ > > > Testing > ------- > > No testing can be done, as these are just helper classes. > Compiles fine > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
