> On June 25, 2015, 7:28 p.m., Dennis Nienhüser wrote: > > src/lib/marble/geodata/data/GeoDataFeature.h, line 85 > > <https://git.reviewboard.kde.org/r/124154/diff/1/?file=381164#file381164line85> > > > > If it doesn't take too much time, please split off the changes in this > > patch which clean up whitespace and commit them directly to master. That > > way the real changes are easier to spot (here and in the future when > > looking at the git history).
Of course, thanks for pointing it out, I didn't even notice it. My editor is set to delete the trailing white-spaces on saveges and that caused these unintentional changes. - Dávid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124154/#review81754 ----------------------------------------------------------- On June 23, 2015, 12:01 p.m., Dávid Kolozsvári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124154/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 12:01 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch introduces a new virtual method > `GeoGraphicsItem::createDecoration()` to enable the easy creation of > decoration for every class thet is inherited from `GeoGraphicsItem`. > > There are two new decorations implemented in this patch: > > + Outlines for `GeoLineStringGraphicsItem`, for better street rendering in > OSM vector tiles; > + Fake3D effect for `GeoPolygonGraphicsItem` if they represent buildings in > OSM vector tiles. > > For performance reasons these decorations are only painted when the map > quality is set to noraml or higher. > > Other changes: > > + Changed some of the color styles of OSM related items, e.g. streets, to > match the default color scheme of [openstreetmap > maps](http://www.openstreetmap.org/); > + Implemented two new OSM feature: `HighwayFootway` and `HighwayCycleway`. > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 > src/lib/marble/geodata/data/GeoDataFeature.cpp 6f330fb > src/lib/marble/geodata/data/GeoDataFeature_p.h 496c356 > src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.h 4842809 > src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.h f469dfb > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp 81cfe9a > src/lib/marble/graphicsview/GeoGraphicsItem.h 4ca4727 > src/lib/marble/graphicsview/GeoGraphicsItem.cpp b8fa693 > src/lib/marble/graphicsview/GeoGraphicsItem_p.h 01becfc > src/lib/marble/layers/GeometryLayer.cpp 9eb3f50 > > Diff: https://git.reviewboard.kde.org/r/124154/diff/ > > > Testing > ------- > > In the end, I've decided to cache the decorations for every item, and thus > the performance is much better than in the [previous review > request](https://git.reviewboard.kde.org/r/124074/). > This patch works for me and the results are better than I expected. > > > Thanks, > > Dávid Kolozsvári > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
