----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124271/#review82285 -----------------------------------------------------------
Ship it! Looks good to me. - Dennis Nienhüser On July 6, 2015, 12:41 p.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124271/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 12:41 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch is moving userAgent() from TinyWebBrowser to HttpDownloadManager, > this is good because this resolves a lot of dependencies on TinyWebBrowser > which depends on QtWebKit. > > > Diffs > ----- > > src/lib/marble/HttpDownloadManager.h > 2899edd1851c087f73bafd57359e27b64906dbcc > src/lib/marble/HttpDownloadManager.cpp > 526fa2a9f3c9a40f8dbaf84a5fb94f66fe85c730 > src/lib/marble/HttpJob.cpp 249b6800a4c0bfbc944020eb25019400bd4eff34 > src/lib/marble/TinyWebBrowser.h 4e94eb5cf69710247d11358827ff7056f9253493 > src/lib/marble/TinyWebBrowser.cpp 52e88422c7bd3754a5235705b2de43ad77ed1437 > src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp > 3fe8ce9cd24a3e4e1d6a7d2590c658349bcd8c60 > src/plugins/runner/mapquest/MapQuestRunner.cpp > 992a350c05e95abc0cb15aea6328477b8a933879 > > src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp > 37fa817e463a0e87a59b68dba56df4aec07f3186 > src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp > cbe87ed91fd862b4631d35256038e152ec57e4ec > src/plugins/runner/open-source-routing-machine/OSRMRunner.cpp > 1ce0d4b2f356fb3100c1c0b6138252097b778add > > Diff: https://git.reviewboard.kde.org/r/124271/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
