> On júl. 9, 2015, 7:44 du, Dennis Nienhüser wrote: > > src/lib/marble/EnumWrappers.h, line 24 > > <https://git.reviewboard.kde.org/r/124297/diff/1/?file=383773#file383773line24> > > > > Wouldn't this be better placed inside MarbleQuickItem? It is a QObject > > already, so just moving the enum (and the Q_ENUMS call) there should suffice
Thank you for the suggestion :) - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124297/#review82282 ----------------------------------------------------------- On júl. 10, 2015, 12:37 du, Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124297/ > ----------------------------------------------------------- > > (Updated júl. 10, 2015, 12:37 du) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > These are added to solve the todo in the example. > > map()->setShowFrameRate(false); > map()->setProjection(Spherical); > map()->setMapThemeId("earth/openstreetmap/openstreetmap.dgml"); > map()->setShowAtmosphere(false); > map()->setShowCompass(false); > map()->setShowClouds(false); > map()->setShowCrosshairs(false); > map()->setShowGrid(false); > map()->setShowOverviewMap(false); > map()->setShowOtherPlaces(false); > map()->setShowScaleBar(false); > map()->setShowBackground(false); > > The modification of the example will be in the following patch. > > > Diffs > ----- > > src/lib/marble/CMakeLists.txt 8b36d0843f585c09c62bf044d0cfb0651a13d4b0 > src/lib/marble/EnumWrappers.h PRE-CREATION > src/lib/marble/EnumWrappers.cpp PRE-CREATION > src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 > src/lib/marble/MarbleQuickItem.cpp 94a0a1a498d4be29778f055d6c05bb532f12ee44 > > Diff: https://git.reviewboard.kde.org/r/124297/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
