----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124231/ -----------------------------------------------------------
(Updated July 10, 2015, 12:48 p.m.) Review request for Marble. Changes ------- fixed issues Repository: marble Description ------- See comment on the header on what the class is for: A new folder lib/marble/osm was created because more sources will come in the following patches. Those sources are needed by both the Osm and Annotate plugins, but also the lib itself. I have tried several approaches for managing osm data, and this seemed the most feasible. I have tried making it polymorphic, ( OsmWayData: OsmPlacemarkData and OsmRelationData: OsmPlacemarkData ) but that approach really made things more complicated and seemed a bit like overdesigning for a simple data container class this is. The empty QHashes barely use any memory, so it should be great. Diffs (updated) ----- src/lib/marble/CMakeLists.txt 8b36d08 src/lib/marble/geodata/data/GeoDataCoordinates.h 7b291cc src/lib/marble/osm/CMakeLists.txt PRE-CREATION src/lib/marble/osm/OsmPlacemarkData.h PRE-CREATION src/lib/marble/osm/OsmPlacemarkData.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124231/diff/ Testing ------- Thanks, Marius Stanciu
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
