----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124233/#review82402 -----------------------------------------------------------
src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp (line 61) <https://git.reviewboard.kde.org/r/124233/#comment56782> typo, members src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp (line 67) <https://git.reviewboard.kde.org/r/124233/#comment56783> What about a more descriptive error message a la "Malformed relation %relid: No way with id %wayid exists" src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp (line 77) <https://git.reviewboard.kde.org/r/124233/#comment56784> typo, polygons src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp (line 55) <https://git.reviewboard.kde.org/r/124233/#comment56785> what about having a method in OsmParser that helps doing this? Would avoid some duplication in OsmNodeTagHandler.cpp, OsmRelationTagHandler.cpp and OsmWayTagHandler.cpp - Dennis Nienhüser On July 10, 2015, 12:51 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124233/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 12:51 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Sorry about this long patch, but i really could not separate it. > Even though it looks long, it's mostly refactoring, not many important > changes, apart from creating the OsmPlacemarkData objects. > > > Diffs > ----- > > src/plugins/runner/osm/OsmParser.h 4436680 > src/plugins/runner/osm/OsmParser.cpp 7ad467b > src/plugins/runner/osm/handlers/OsmElementDictionary.h 44a993c > src/plugins/runner/osm/handlers/OsmElementDictionary.cpp f493e7b > src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 8fdfaae > src/plugins/runner/osm/handlers/OsmNdTagHandler.cpp 3183560 > src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp e8dc85f > src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 5d900ba > src/plugins/runner/osm/handlers/OsmTagTagHandler.h d4749da > src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp deaf32e > src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp df15102 > > Diff: https://git.reviewboard.kde.org/r/124233/diff/ > > > Testing > ------- > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
