----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124099/#review82414 -----------------------------------------------------------
src/plugins/render/annotate/AnnotatePlugin.cpp (line 87) <https://git.reviewboard.kde.org/r/124099/#comment56797> comment does not match code (and is not needed in my opinion: "don't comment the obvious") src/plugins/render/annotate/AnnotatePlugin.cpp (line 354) <https://git.reviewboard.kde.org/r/124099/#comment56798> please remove src/plugins/render/annotate/AnnotatePlugin.cpp (line 385) <https://git.reviewboard.kde.org/r/124099/#comment56799> please remove - Dennis Nienhüser On July 10, 2015, 12:55 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124099/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 12:55 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Choosing .osm file format when saving annotation file now correctly outputs > osm files. > > > Diffs > ----- > > src/plugins/render/annotate/AnnotatePlugin.cpp c711ccb > src/plugins/runner/osm/CMakeLists.txt 4a341e7 > > Diff: https://git.reviewboard.kde.org/r/124099/diff/ > > > Testing > ------- > > I have created a bunch of features in the editor ( polygon with hole, > polylines, placemarks ), exported them to ".osm" file > Imported the newly created ".osm" file. > Exported it to another ".osm" file. > > The initial file and the final one are the same ( except order difference > caused by QHash mechanism ) > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
