> On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote: > > src/apps/marble_maps/SearchBar.qml, line 23 > > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384487#file384487line23> > > > > shouldn't this rather use the height of text?
Maybe this is a little bit too small (check the screenshot). Usually the UI's have bigger elements to be more touch "friendly". Which version is better? > On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote: > > src/apps/marble_maps/SearchBar.qml, line 61 > > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384487#file384487line61> > > > > i'd rather have the icon (Image) set the size I tried to do that with the width and height properties of the image, but it does nothing. I have to set the button's size or it will be unvisible. Maybe I do something in the wrong way? > On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote: > > src/apps/marble_maps/SearchBar.qml, line 65 > > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384487#file384487line65> > > > > I'd prefer using a property for Image.source. The property itself can > > listen to signals of the searchButton to change its values. This allows QML > > to do all updates on its own. > > (just a thought, there might be blockers) I have dropped out the function. What do you think about now? > On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote: > > src/apps/marble_maps/SearchBarBackend.h, line 36 > > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384488#file384488line36> > > > > A const reference should be possible here also I changed the model to MarblePlacemarkModel. - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124327/#review82396 ----------------------------------------------------------- On júl. 13, 2015, 6:09 du, Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124327/ > ----------------------------------------------------------- > > (Updated júl. 13, 2015, 6:09 du) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch adds a search bar to Marble Maps. Because the loading of the > plugins not works on Android, the search function is not working. > > > Diffs > ----- > > src/apps/marble_maps/QmlView.cpp PRE-CREATION > src/apps/marble_maps/QmlView.h PRE-CREATION > src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION > src/apps/marble_maps/MainScreen.qml PRE-CREATION > src/apps/marble_maps/CMakeLists.txt PRE-CREATION > data/android/pixmaps/searchUnpressed.png PRE-CREATION > data/android/pixmaps/searchPressed.png PRE-CREATION > data/android/pixmaps/searchFocused.png PRE-CREATION > src/apps/marble_maps/SearchBar.qml PRE-CREATION > src/apps/marble_maps/SearchBarBackend.h PRE-CREATION > src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION > src/apps/marble_maps/main.cpp PRE-CREATION > src/lib/marble/MarblePlacemarkModel.cpp > a2c78c4f8603752182f64e42e02a585d5ea6b2e3 > src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 > src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp > 7c1803998ce5a01e338f2eb04a2b7f310a926c26 > src/plugins/runner/yours/YoursRunner.cpp > 4b1c0552718acc4a2f3070e95950975a57d4fdd4 > > Diff: https://git.reviewboard.kde.org/r/124327/diff/ > > > Testing > ------- > > On linux it works fine when the runner plugins are loaded. On Android the UI > appears fine but not working with loaded plugins. > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png > Screenshot 2 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png > Screenshot 3 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
