----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124337/#review82460 -----------------------------------------------------------
The approach looks more like a hack, but given that it is pretty short and tied to ANDROID only let's go for it. We can evaluate at a later point whether we can link against all needed plugins on Android directly, then change plugin manager to retrieve their meta info directly from #including their headers. src/CMakeLists.txt (line 50) <https://git.reviewboard.kde.org/r/124337/#comment56859> I don't think that option makes sense really. If the libs are not built, nothing else can be build really. Do you have a use-case in mind for this? src/CMakeLists.txt (line 63) <https://git.reviewboard.kde.org/r/124337/#comment56860> we already have a switch EXPERIMENTAL_PYTHON_BINDINGS inside that subdirectory. I'd rather keep that instead of introducing another option for it. src/lib/marble/PluginManager.cpp (line 67) <https://git.reviewboard.kde.org/r/124337/#comment56863> Could be const src/lib/marble/PluginManager.cpp (line 251) <https://git.reviewboard.kde.org/r/124337/#comment56861> "" => QString() It's one of the common complaints of the krazy2 check, let's just avoid it in the first place ;-) src/lib/marble/PluginManager.cpp (line 255) <https://git.reviewboard.kde.org/r/124337/#comment56856> const QString &file src/lib/marble/PluginManager.cpp (line 257) <https://git.reviewboard.kde.org/r/124337/#comment56862> "/" => '/' same reason as above (krazy2), same for the other ones below src/lib/marble/PluginManager.cpp (line 258) <https://git.reviewboard.kde.org/r/124337/#comment56857> please don't put the opening bracket in a new line, see https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Braces src/lib/marble/PluginManager.cpp (line 263) <https://git.reviewboard.kde.org/r/124337/#comment56858> f => file (no abbreviations except very common ones like i, see https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Variable_declaration - Dennis Nienhüser On July 13, 2015, 10:09 a.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124337/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 10:09 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > With this patch plugins what are placed into assets/plugins automatically > will be copied into the app's local data directory, and after that they can > be loaded by Marble Maps. > An other modification that runner plugins can be compiled for Android, so > they now can be included. For the how, please check the techbase install > guide. > > > Diffs > ----- > > CMakeLists.txt de4a9dc39b948385bdde574dcdb673a9938a186f > src/CMakeLists.txt 78b83a39ac26b17b82b072d6309bb30d88bf6534 > src/apps/marble_maps/CMakeLists.txt PRE-CREATION > src/lib/marble/CMakeLists.txt 8b36d0843f585c09c62bf044d0cfb0651a13d4b0 > src/lib/marble/MarbleDirs.cpp 8dd3fe07cd12672df21faa23369c887e566b176d > src/lib/marble/PluginManager.h a4ae1421ff1ed4036472b4bbcb216bb5d4f205a5 > src/lib/marble/PluginManager.cpp f323b4ffa0a92b6ab5de3a73a13ce16bf609380b > src/plugins/CMakeLists.txt 011b77ae520875619f20379b32b731af0028a90d > > Diff: https://git.reviewboard.kde.org/r/124337/diff/ > > > Testing > ------- > > It works fine on my phone. > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
