----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124362/#review82647 -----------------------------------------------------------
Ship it! Thanks! I'll push it on your behalf. - Dennis Nienhüser On July 15, 2015, 2:14 p.m., Gilbert Assaf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124362/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 2:14 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Fixed: > Check for code that should be considered crashy > Check single-char QString operations for efficiency > Check for foreach loop issues > > > Diffs > ----- > > src/apps/marble-kde/kdemain.cpp 3303a943dab3861183170fc12bfee231cc38f551 > src/apps/marble-qt/QtMainWindow.cpp > ff8102637c6473fe494ab82cf01e7f761c52724c > src/lib/marble/MarbleModel.cpp 04605c6f7261d03e720a3c071a63f459f982d909 > src/lib/marble/MovieCapture.cpp c95c70167dd0003615ac5d38abf853c442e7bda7 > src/lib/marble/PlacemarkEditHeader.cpp > d7c3c5d725e21b61e94a661a5c468c439770df18 > src/lib/marble/TourWidget.cpp 90b8c2b57f3ae00cd568e514efa266628a513cb4 > src/plugins/render/stars/StarsPlugin.cpp > b6df5c38874412d56682de2c3a04a3aeda26ed0b > > Diff: https://git.reviewboard.kde.org/r/124362/diff/ > > > Testing > ------- > > > Thanks, > > Gilbert Assaf > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
