----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124396/#review82649 -----------------------------------------------------------
src/apps/marble_maps/MenuItem.qml (line 3) <https://git.reviewboard.kde.org/r/124396/#comment57000> As explained before the hierarchy is messed up. Right now your MenuItem _is_ a rectangle which _is_ the background. Also the root element should always have the id "root". So the menuItem should look like this: Item { id: root Rectangle { id: background color: "#1a1a1a" anchors.fill: parent } GridView { id: gridView anchors.fill: parent } } Please fix. - Torsten Rahn On Juli 19, 2015, 3:35 nachm., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124396/ > ----------------------------------------------------------- > > (Updated Juli 19, 2015, 3:35 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This adds a menu to Marble Maps. It uses a gridview to present the model. > This patch also autohides the search bar. It appears when the user selects it > from the menu. > > > Diffs > ----- > > data/android/pixmaps/searchMenuIcon.png PRE-CREATION > src/apps/marble_maps/MainScreen.qml PRE-CREATION > src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION > src/apps/marble_maps/MenuItem.qml PRE-CREATION > src/apps/marble_maps/MenuModel.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124396/diff/ > > > Testing > ------- > > Works fine on my device. > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
