> On July 18, 2015, 6:21 p.m., Dennis Nienhüser wrote: > > Where are the three icons from? We can only use icons with a compatible > > license. Can you attach them to the review request? Binary files cannot be > > added to reviewboard patches directly. > > Gábor Péterffy wrote: > I drawed them in gimp. Sure I am uploading them.
Great, thanks. We won't be able to do all icons we need on our own though. What about using an existing icon pack? What about https://www.google.com/design/icons/index.html for example? @Torsten: Would like your opinion on which icons to use as well :-) - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124327/#review82618 ----------------------------------------------------------- On July 19, 2015, 3:44 p.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124327/ > ----------------------------------------------------------- > > (Updated July 19, 2015, 3:44 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch adds a search bar to Marble Maps. Because the loading of the > plugins not works on Android, the search function is not working. > > > Diffs > ----- > > data/android/pixmaps/searchFocused.png PRE-CREATION > data/android/pixmaps/searchPressed.png PRE-CREATION > data/android/pixmaps/searchReleased.png PRE-CREATION > src/apps/marble_maps/CMakeLists.txt PRE-CREATION > src/apps/marble_maps/MainScreen.qml PRE-CREATION > src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION > src/apps/marble_maps/QmlView.h PRE-CREATION > src/apps/marble_maps/QmlView.cpp PRE-CREATION > src/apps/marble_maps/SearchBar.qml PRE-CREATION > src/apps/marble_maps/SearchBarBackend.h PRE-CREATION > src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION > src/apps/marble_maps/main.cpp PRE-CREATION > src/lib/marble/MarblePlacemarkModel.cpp > a2c78c4f8603752182f64e42e02a585d5ea6b2e3 > src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 > src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp > 7c1803998ce5a01e338f2eb04a2b7f310a926c26 > src/plugins/runner/yours/YoursRunner.cpp > 4b1c0552718acc4a2f3070e95950975a57d4fdd4 > > Diff: https://git.reviewboard.kde.org/r/124327/diff/ > > > Testing > ------- > > On linux it works fine when the runner plugins are loaded. On Android the UI > appears fine but not working with loaded plugins. > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png > Screenshot 2 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png > Screenshot 3 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png > searchFocused.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/4fc5e41a-40aa-4d62-879c-6436e93dd1a0__searchFocused.png > searchPressed.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/c16c83c4-d25f-482d-b409-7cece2f7bad0__searchPressed.png > searchReleased.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/58b3d964-641d-457f-911e-62066d55cf61__searchReleased.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
