> On July 23, 2015, 12:09 a.m., Dennis Nienhüser wrote: > > The code in question was added to fix > > https://bugs.kde.org/show_bug.cgi?id=342775 > > Can you check if you can reproduce the problem mentioned there?
Hmm, bug indeed. Needs a fix. - Sanjiban ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124421/#review82830 ----------------------------------------------------------- On July 22, 2015, 11:38 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124421/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 11:38 p.m.) > > > Review request for Marble, Dennis Nienhüser and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > There was an unnecessary check at the beginning of the function because of > which the flow was never going down to the point where it should start > playing the route as tour. Removed the, and the route preview takes place as > required now. > > > Diffs > ----- > > src/lib/marble/routing/RoutingWidget.cpp e3e6d9c > > Diff: https://git.reviewboard.kde.org/r/124421/diff/ > > > Testing > ------- > > Tested. Works. > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
