----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124441/#review82847 -----------------------------------------------------------
src/apps/marble_maps/MainScreen.qml (line 32) <https://git.reviewboard.kde.org/r/124441/#comment57149> please keep opening brackets on the same line. I think we can go non-fullscreen. We should pay attention that the buttons (especially back button) behave sane though. - Dennis Nienhüser On Juli 23, 2015, 8:28 nachm., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124441/ > ----------------------------------------------------------- > > (Updated Juli 23, 2015, 8:28 nachm.) > > > Review request for Marble and Gábor Péterffy. > > > Repository: marble > > > Description > ------- > > Move Marble Maps to QQmlApplicationEngine and QtQuick components. > > Add basic menubar and toolbar. Use "Holo Dark" Android theme. > > > Diffs > ----- > > src/apps/marble_maps/CMakeLists.txt a259af7 > src/apps/marble_maps/MainScreen.qml 96238c5 > src/apps/marble_maps/QmlView.h b312d9a > src/apps/marble_maps/QmlView.cpp 6c4fc70 > src/apps/marble_maps/main.cpp 473ff44 > src/apps/marble_maps/package/AndroidManifest.xml 9125e5d > > Diff: https://git.reviewboard.kde.org/r/124441/diff/ > > > Testing > ------- > > Works on Nexus 5 & Nexus 9 (both Android 5.1.1). > > Noticed issues: > - After clicking on menu navbar appears (see screenshot) and it doesn't hide. > I tried to add simple TextField and after: 1) clicking on it; 2) closing > keyboard; navbar hides. So, looks it's something focus-related. > > Also, do we even need to go to fullscreen (immersive mode)? For example > Google Earth and Google Maps doesn't use it. > > > File Attachments > ---------------- > > Holo Dark 2.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/8c561590-4e50-47f2-83ab-44b883c4f51c__Holo_Dark_2.png > Holo Dark 3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/63c4a2ff-ea1d-47d9-a004-46cc056d7468__Holo_Dark_3.png > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
