----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124490/#review83062 -----------------------------------------------------------
Applied the patch, builds But no translations in locale x-test (faked locale "zu" because Qt does not know x-test) and locale "de" from marble_qt in the GUI - Burkhard Lück On Juli 27, 2015, 1:59 nachm., Dennis Nienhüser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124490/ > ----------------------------------------------------------- > > (Updated Juli 27, 2015, 1:59 nachm.) > > > Review request for Marble and Burkhard Lück. > > > Bugs: 350589 > http://bugs.kde.org/show_bug.cgi?id=350589 > > > Repository: marble > > > Description > ------- > > Attempts to fix bug 350589, loading of the marble_qt translation catalog. As > ECM is an optional dependency for us I extracted its ecm_create_qm_loader > logic into the loadTranslations() and loadTranslation() methods. They're > called from the Qt and the KDE Marble applications. > > I'll intend to backport this in case it works. > > Note that this removes the previous translation loading logic in the Qt > Marble application which was searching different locations. > > > Diffs > ----- > > src/apps/marble-kde/kdemain.cpp 6ce2e39 > src/apps/marble-qt/qtmain.cpp 9c709b0 > src/apps/marble-ui/ControlView.h caf99b8 > src/apps/marble-ui/ControlView.cpp 0fe1b21 > > Diff: https://git.reviewboard.kde.org/r/124490/diff/ > > > Testing > ------- > > So far just tested compilation. > > > Thanks, > > Dennis Nienhüser > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel