----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124522/ -----------------------------------------------------------
Review request for Marble. Repository: marble Description ------- This completes the parsing/writing cycle: load ".osm" -> export as ".kml" -> import ".kml" -> export ".osm" -> repeat I have made the custom XML schema very verbose, so as to be understandable. One small change had to be done: ExtendedData is now written after the Geometry within a <Placemark> tag ( @see change in KmlFeatureTagWriter.cpp ) ( OsmPlacemarkData depends on the geometry, so that has to be initialized before, when parsing ".kml" files ) Diffs ----- src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.cpp PRE-CREATION src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.h PRE-CREATION src/lib/marble/geodata/writers/kml/KmlFeatureTagWriter.cpp f4a77ff src/lib/marble/geodata/handlers/kml/KmlTagTagHandler.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlTagTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.cpp PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.h PRE-CREATION src/lib/marble/geodata/CMakeLists.txt cb89e7f src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.h PRE-CREATION src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124522/diff/ Testing ------- created stuff within editor then done the cycle: export as ".osm" ----> load ".osm" ----> export as ".kml" ----> import ".kml" ----> export ".osm" compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by the QHash mechanism ) Unit tests coming soon. Thanks, Marius Stanciu
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
