> On júl. 29, 2015, 9:31 de, Dennis Nienhüser wrote: > > src/lib/marble/MarbleQuickItem.cpp, line 347 > > <https://git.reviewboard.kde.org/r/124519/diff/1/?file=388506#file388506line347> > > > > can't we use `!coordinates.isValid()` here?
The coordinate is valid. It points to 0,0,0. - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124519/#review83125 ----------------------------------------------------------- On júl. 29, 2015, 1:04 de, Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124519/ > ----------------------------------------------------------- > > (Updated júl. 29, 2015, 1:04 de) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch introduces the CircleButton qml type. Based on this there is a > button now which navigates the map at the current position. The button should > be visible if the position is known. > > I have also updated the icons. I think with using black borders for white > icons we can handle both the dark and the light themes. > > > Diffs > ----- > > data/android/drawable-xxxhdpi/locate.png PRE-CREATION > data/android/drawable-xxxhdpi/search.png > 599a3c7ccdcedb11835378562f7f34c2a4c39669 > src/apps/marble-maps/CircleButton.qml PRE-CREATION > src/apps/marble-maps/MainScreen.qml > 5552a54eca8b37fa17588a14a035927418b23fbe > src/apps/marble-maps/MarbleMaps.qrc > c24c38a507da4a8d41729d61fc23035d6f75a446 > src/lib/marble/MarbleQuickItem.h 21b8fe5c4570ac894f668603a660da81f1d8a8e4 > src/lib/marble/MarbleQuickItem.cpp ee8bae8ea379cae3a0e6378259622a1ad88f8a2b > > Diff: https://git.reviewboard.kde.org/r/124519/diff/ > > > Testing > ------- > > It seems calling update() stops for the position providing plugin when I turn > off the locationing -> It can not hide the button, because no signal has been > emitted about status change. Any ideas? > > > File Attachments > ---------------- > > search.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/d1e80eda-39e0-4c53-b09a-59b115d95785__search.png > locate.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/8461a526-bfbf-4298-af71-e99616964e62__locate.png > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/5b1f5fe0-d02d-415e-aa49-3cf20dedab0b__Screenshot_2015-07-29-00-49-51.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
