> On júl. 31, 2015, 2:12 du, Gábor Péterffy wrote: > > src/apps/marble-maps/Completion.qml, line 33 > > <https://git.reviewboard.kde.org/r/124541/diff/1/?file=388796#file388796line33> > > > > I suggest > > background: palette.window
After having a look at Dennis's mockup I changed my mind :) - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/#review83226 ----------------------------------------------------------- On júl. 31, 2015, 9:25 de, Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124541/ > ----------------------------------------------------------- > > (Updated júl. 31, 2015, 9:25 de) > > > Review request for Marble and Gábor Péterffy. > > > Repository: marble > > > Description > ------- > > Added search completion for Marble Maps. > > > Diffs > ----- > > src/apps/marble-maps/Completion.qml PRE-CREATION > src/apps/marble-maps/MainScreen.qml 2cc996a > src/apps/marble-maps/MarbleMaps.qrc d027af9 > src/apps/marble-maps/Search.qml 896f266 > src/apps/marble-maps/SearchField.qml 5830098 > src/apps/marble-maps/SearchResults.qml a910038 > src/lib/marble/declarative/SearchBackend.h b041de3 > src/lib/marble/declarative/SearchBackend.cpp 5c80cc3 > > Diff: https://git.reviewboard.kde.org/r/124541/diff/ > > > Testing > ------- > > Works on Nexus 5 and Nexus 9 (both are Android 5.1.1) > > I'm not sure about color for background so I created a screenshot which shows > all available colors from SystemPalette with default Holo Dark theme on stock > Android 5.1.1. > > > File Attachments > ---------------- > > Screenshot_2015-07-30-22-54-35.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dea46243-b94d-42d2-b875-9b10ba8aa878__Screenshot_2015-07-30-22-54-35.png > Screenshot_2015-07-30-22-54-40.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ad18ee94-de67-4270-a2a6-4b51617151d9__Screenshot_2015-07-30-22-54-40.png > Screenshot_2015-07-30-22-54-44.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/1384d028-7ce9-4e90-badf-37c3959c3506__Screenshot_2015-07-30-22-54-44.png > Screenshot_2015-07-31-11-23-06.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/bb227912-4acb-4083-b7ff-ea5704aec909__Screenshot_2015-07-31-11-23-06.png > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
