----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124498/ -----------------------------------------------------------
(Updated Aug. 5, 2015, 4:57 p.m.) Review request for Marble. Changes ------- Corrected some of the issues pointed out by Torsten Rahn, using q-pointer as suggested(the link was a great help). Repository: marble Description ------- With this patch, the street labels are renedered properly in OSM Vector Tiles. For each type of OSM way, a custom font style and color can be defined. They even follow the curvatures of the streets without any major performance impact. As for the font styles, I welcome any suggestions in the commemnts. Diffs (updated) ----- src/lib/marble/ClipPainter.h 42b73c0 src/lib/marble/ClipPainter.cpp 473436e src/lib/marble/GeoPainter.h 7a757b9 src/lib/marble/GeoPainter.cpp d04138c src/lib/marble/GeoPainter_p.h f0c4f9b src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 src/lib/marble/geodata/data/GeoDataFeature.cpp 6f330fb src/lib/marble/geodata/data/GeoDataFeature_p.h 496c356 src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 src/lib/marble/layers/GeometryLayer.cpp 9eb3f50 Diff: https://git.reviewboard.kde.org/r/124498/diff/ Testing ------- I was worried about the performance impact, because my initial idea was too slow, but after several changes, this version works pretty good. Thanks, Dávid Kolozsvári
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
