----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124787/ -----------------------------------------------------------
Review request for Marble. Repository: marble Description ------- why exactly the build works for anyone without the moc is beyond me, the include however is supposedly necessary as documented at [1]. otherwise the factory (object created by the macro) metaobject code is not present and the factory linking fails on the missing vtable. this is reproducible on cmake 3.2.2, gcc5 and frameworks 5.13. additionally include the KDECMakeSettings from ECM as to enable current_binary_directory includes by default (which is necessary to find main.moc) [1] https://techbase.kde.org/Development/Tutorials/Plasma4/AbstractRunner#The_Plugin_Declaration_Macro Diffs ----- src/plasmarunner/CMakeLists.txt 32591ef6bfc7b41ca644f5ec34fbdb97225f5749 src/plasmarunner/main.cpp 43c30bb2dcb3d078e6f214aaab23e2688399354f Diff: https://git.reviewboard.kde.org/r/124787/diff/ Testing ------- successfully built with all kde shebang present Thanks, Harald Sitter
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
