> On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote: > > I like the interaction with waypoints directly in the map. We need some > > bugfixes and tweaks still: > > - when the search result is selected and appears on the map, its menu > > should be opened > > - if you change existing waypoints from departure or destination to a via > > point, they are sometimes excluded from the route > > - the waypoint icons in 'Modify Route' are sometimes incorrect > > - if you change all waypoints to search results (why is that an option at > > all?), the app crashes
I think it is a cool thing that you can set everything into an undecided state and after it you can recreate the route as you want without the waypoint editor, so this is a more visual approach. Can you give me some instructions how to reproduce the incorrect icon bug? I have no luck to produce it. > On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote: > > src/apps/marble-maps/Waypoint.qml, line 65 > > <https://git.reviewboard.kde.org/r/124666/diff/5/?file=395080#file395080line65> > > > > syntax error, isn't it? You are right, but apparently it worked without an error message. > On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote: > > src/lib/marble/declarative/Routing.h, line 107 > > <https://git.reviewboard.kde.org/r/124666/diff/5/?file=395083#file395083line107> > > > > const QVariant & > > > > In general, method parameters that are not going to be modified by the > > function are passed > > - by value for simple pod types (bool, int, float, double, enums) > > - by const reference for everything else, including smart pointers and > > data types with copy-on-write semantics Thank you for the explanation. > On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote: > > src/lib/marble/declarative/Routing.cpp, line 25 > > <https://git.reviewboard.kde.org/r/124666/diff/5/?file=395084#file395084line25> > > > > seems unrelated to me? It is used when we calculate the route from the current location. > On Aug. 16, 2015, 6:20 p.m., Dennis Nienhüser wrote: > > src/lib/marble/declarative/Routing.cpp, line 261 > > <https://git.reviewboard.kde.org/r/124666/diff/5/?file=395084#file395084line261> > > > > The tight coupling between QML and C++ in Routing::prepareMenu and > > Routing::handleSelectedMenuOption is quite awkward. Can't we handle all > > that directly in QML? We can, I have fixed this. - Gábor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124666/#review83886 ----------------------------------------------------------- On Aug. 18, 2015, 1:06 a.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124666/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 1:06 a.m.) > > > Review request for Marble, Mihail Ivchenko and Dennis Nienhüser. > > > Repository: marble > > > Description > ------- > > - Working back button > - Reworked navigation setup > > > Diffs > ----- > > data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION > data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION > data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION > data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION > data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION > data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION > src/apps/marble-maps/CircularMenu.qml PRE-CREATION > src/apps/marble-maps/MainScreen.qml cb88a0c > src/apps/marble-maps/MarbleMaps.qrc 1cba58d > src/apps/marble-maps/RoutePlanViewer.qml 4ca794e > src/apps/marble-maps/RoutingManager.qml 6434bff > src/apps/marble-maps/Search.qml 69ecc0a > src/apps/marble-maps/Waypoint.qml PRE-CREATION > src/apps/marble-maps/WaypointImage.qml 9b0aa01 > src/apps/marble-maps/WaypointOrderManager.qml c77a460 > src/lib/marble/declarative/Routing.h a1e93c5 > src/lib/marble/declarative/Routing.cpp 38e0d66 > > Diff: https://git.reviewboard.kde.org/r/124666/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > delete_white.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png > ic_place_via.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png > ic_place_unknown.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png > ic_place_departure.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png > ic_place_arrival.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png > circular_menu_backdrop.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
