----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124511/#review84111 -----------------------------------------------------------
Ship it! src/lib/marble/GeoPainter.h (line 312) <https://git.reviewboard.kde.org/r/124511/#comment58247> Arial is a proprietary font, I'd rather not make it a default. What about using GeoDataFeature::defaultFont() instead? src/lib/marble/GeoPainter.cpp (line 39) <https://git.reviewboard.kde.org/r/124511/#comment58248> m_q for the member variable name, or m_parent, or m_geoPainter src/lib/marble/GeoPainter.cpp (line 181) <https://git.reviewboard.kde.org/r/124511/#comment58249> this normalization seems a bit overcomplicated, what's the intention? - Dennis Nienhüser On Aug. 19, 2015, 4:25 p.m., Dávid Kolozsvári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124511/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 4:25 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > I changed a little bit the decoration creating method, it now uses a QList to > store the decorations, so multiple decorations can be added this way. It was > an idea for the street labeling, but it makes sense without that too. > > > Diffs > ----- > > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp 81cfe9a > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.h f469dfb > src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 > src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.h 4842809 > src/lib/marble/geodata/data/GeoDataFeature_p.h 962f0d5 > src/lib/marble/geodata/data/GeoDataFeature.cpp 4443162 > src/lib/marble/GeoPainter.h 7a757b9 > src/lib/marble/GeoPainter.cpp d04138c > src/lib/marble/GeoPainter_p.h f0c4f9b > src/lib/marble/MarbleGlobal.h 8ba5b2d > src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 > src/lib/marble/graphicsview/GeoGraphicsItem.h 4ca4727 > src/lib/marble/graphicsview/GeoGraphicsItem.cpp b8fa693 > src/lib/marble/graphicsview/GeoGraphicsItem_p.h 01becfc > src/lib/marble/layers/GeometryLayer.cpp 11eca7d > > Diff: https://git.reviewboard.kde.org/r/124511/diff/ > > > Testing > ------- > > It works on a freshly pulled version of Marble. > > > Thanks, > > Dávid Kolozsvári > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
