----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124808/#review84183 -----------------------------------------------------------
src/apps/marble-maps/NavigationManager.qml (line 23) <https://git.reviewboard.kde.org/r/124808/#comment58314> is nullptr valid QML? src/lib/marble/declarative/MarbleQuickItem.h (line 56) <https://git.reviewboard.kde.org/r/124808/#comment58315> I think direction or heading is a better name - Dennis Nienhüser On Aug. 20, 2015, 10:08 p.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124808/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 10:08 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > It adds navigation to Marble Maps. I extended the existing Navigation class. > > > Diffs > ----- > > CMakeLists.txt 5b53ff8 > data/android/drawable-xxxhdpi/navigation_blue.png PRE-CREATION > data/svg/turn-around.svg 11a41e7 > data/svg/turn-continue.svg 8e865c5 > data/svg/turn-exit-left.svg 526c750 > data/svg/turn-exit-right.svg d5c3317 > data/svg/turn-left.svg 94e6383 > data/svg/turn-merge.svg 529d050 > data/svg/turn-right.svg d48a9ef > data/svg/turn-roundabout-far.svg a708412 > data/svg/turn-roundabout-first.svg b1a63b6 > data/svg/turn-roundabout-second.svg 5b4e222 > data/svg/turn-roundabout-third.svg 47791ff > data/svg/turn-sharp-left.svg 228a1f2 > data/svg/turn-sharp-right.svg 2c7b6b1 > data/svg/turn-slight-left.svg befbe52 > data/svg/turn-slight-right.svg 20bfd63 > src/apps/marble-maps/CMakeLists.txt 33cdaf0 > src/apps/marble-maps/MainScreen.qml cb88a0c > src/apps/marble-maps/MarbleMaps.qrc 1cba58d > src/apps/marble-maps/NavigationInfoBar.qml PRE-CREATION > src/apps/marble-maps/NavigationManager.qml PRE-CREATION > src/apps/marble-maps/PositionMarker.qml PRE-CREATION > src/lib/marble/declarative/MarbleQuickItem.h 1a24034 > src/lib/marble/declarative/MarbleQuickItem.cpp 05fbc9e > src/lib/marble/declarative/Navigation.h 1a2efa7 > src/lib/marble/declarative/Navigation.cpp 57a5392 > src/lib/marble/routing/VoiceNavigationModel.cpp 354d278 > > Diff: https://git.reviewboard.kde.org/r/124808/diff/ > > > Testing > ------- > > It works fine ony my device, I have tested it with a little driving around. > > > File Attachments > ---------------- > > Screenshot_2015-08-18-23-12-11.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/18/f1160c11-8187-4d54-b0f6-d545e4c52e23__Screenshot_2015-08-18-23-12-11.png > navigation_blue.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/5a2d31ab-b85d-4b06-9bda-7e2802d3c8b0__navigation_blue.png > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
