----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124780/#review84378 -----------------------------------------------------------
Ship it! src/lib/marble/osm/OsmTagEditorWidget_p.cpp (line 365) <https://git.reviewboard.kde.org/r/124780/#comment58427> != should be ==, no?! src/lib/marble/osm/CMakeLists.txt (line 6) <https://git.reviewboard.kde.org/r/124780/#comment58426> Does this get installed (copied to include/) then? I don't think we want to install private headers. - Dennis Nienhüser On Aug. 25, 2015, 8:33 p.m., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124780/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 8:33 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > !!! depends on the OsmPresetLibrary patch ( 124672 ) > > If you want to test this separately, add the files manually to the CMakeList > file. > > This widget allows the user to add(remove) tags to placemarks. > The tags can be either selected from a "recommended tags" list, or can be > manually introduced via an "Add custom tag..." item. > > The recommended tag presets are generated based on the current state of the > placemark in the following way: > > - recommendedTags() generates a filter ( using generateTagFilter() ), and > then iterates through the osmPresetLibrary, picking all tags that pass the > filter. > - made an easy, standard way to add criteria to the filter( in case there > are more feasible ones that i have missed ) as you can see in > generateTagFilter(); > > The widget also has a hint function ( suitableTag() ) that returns the tag > that is most fit to represent the visual category of the placemark. > (Currently, the criteria on which that tag is chosen is quite simple ( first > tag ), might have to think of a better one ) > > ! known issue (not really related to this patch): not all visual categories > have their style mapped right in GeoDataFeature.cpp ( eg. > landuse=construction makes the polygon invisible, while landuse=cemetery > works perfectly ) > might fix the styles in a later patch. > > > Diffs > ----- > > src/lib/marble/CMakeLists.txt 68a4b7f > src/lib/marble/osm/CMakeLists.txt 98776a2 > src/lib/marble/osm/OsmTagEditorWidget.h PRE-CREATION > src/lib/marble/osm/OsmTagEditorWidget.cpp PRE-CREATION > src/lib/marble/osm/OsmTagEditorWidget.ui PRE-CREATION > src/lib/marble/osm/OsmTagEditorWidget_p.h PRE-CREATION > src/lib/marble/osm/OsmTagEditorWidget_p.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124780/diff/ > > > Testing > ------- > > testing is done for the next patch ( the ui is not yet integrated in the > annotate plugin ) > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
