----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124989/#review84568 -----------------------------------------------------------
What performance impact does this have? It might affect rendering speed. I would rather extend drawLabelPixmap to take another argument isSelected and then cache two pixmaps, one for the selected case and one for the not selected. Then return the right one based on the value of m_selected. - Dennis Nienhüser On Aug. 30, 2015, 12:02 vorm., Constantin Mihalache wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124989/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 12:02 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > ** bug: **When a placemark is selected (left mouse click) and then > deselected, it's label color does not change accordingly (it stays > highlighted). When deselecting, the color changes to the original one only if > the placemark is dragged out of the screen and then brought back. > > * the main issue is that each VisiblePlacemark's labelPixmap should be > generated exactly before painting. > * this may not be an elegant fix, but it works > > > Diffs > ----- > > src/lib/marble/VisiblePlacemark.h 805112d > src/lib/marble/VisiblePlacemark.cpp 2fdc8ec > > Diff: https://git.reviewboard.kde.org/r/124989/diff/ > > > Testing > ------- > > Created placemarks -> clicked on the icon of the placemark -> label is > highlighted -> clicked on the globe -> label is not highlighted. > > > Thanks, > > Constantin Mihalache > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
