----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125572/#review87539 -----------------------------------------------------------
Ship it! Ship It! - Dennis Nienhüser On Oct. 9, 2015, 7:20 p.m., Antonio Larrosa Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125572/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 7:20 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Since libastro doesn't link to Qt libraries, in order to not keep > an undefined reference to qt_version_tag in libastro, > QT_NO_VERSION_TAGGING has to be defined > > > Diffs > ----- > > src/lib/astro/astrolib_export.h a0f7735696ec34207fc0cd86ed0c7ea766bf026b > > Diff: https://git.reviewboard.kde.org/r/125572/diff/ > > > Testing > ------- > > I tested the patch in > https://build.opensuse.org/package/show/home:alarrosa:branches:KDE:Applications/marble > compiling digikam successfully against it at: > https://build.opensuse.org/package/show/home:alarrosa:branches:KDE:Applications4/digikam > (previously when digikam linked against libastro there was an "undefined > symbol: qt_version_tag" error > > > Thanks, > > Antonio Larrosa Jimenez > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
