> On Dec. 1, 2015, 2 p.m., Torsten Rahn wrote: > > examples/cpp/hello-marble/CMakeLists.txt, line 30 > > <https://git.reviewboard.kde.org/r/126213/diff/1/?file=420275#file420275line30> > > > > This looks like a leftover - actually I wonder whether the whole > > changes of the CMakeLists.txt are supposed to be part of this changeset.
That was added by mistake. > On Dec. 1, 2015, 2 p.m., Torsten Rahn wrote: > > src/lib/marble/osm/OsmPresetLibrary.cpp, line 268 > > <https://git.reviewboard.kde.org/r/126213/diff/1/?file=420278#file420278line268> > > > > you might need to add > > s_visualCategories[ OsmTag( "tourism", "picnic_site" ) ] = > > GeoDataFeature::LeisurePicnicTable; > > as well :) I added that line. Everything is ok now. - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126213/#review88998 ----------------------------------------------------------- On Dec. 1, 2015, 10:23 a.m., Raphael Cojocaru wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126213/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 10:23 a.m.) > > > Review request for Marble and Dennis Nienhüser. > > > Repository: marble > > > Description > ------- > > I added a new entry for the picnic table icon in GeoDataFeature.cpp file. > I followed the "LeisurePlayground" example and created my > "LeisurePicnicTable". > I also modified GeoDataFeature.h and OsmPresetLibrary.cpp. > > > Diffs > ----- > > examples/cpp/hello-marble/CMakeLists.txt 0150782 > src/lib/marble/geodata/data/GeoDataFeature.h 0ed1fce > src/lib/marble/geodata/data/GeoDataFeature.cpp 196922f > src/lib/marble/osm/OsmPresetLibrary.cpp 5e1b6ba > > Diff: https://git.reviewboard.kde.org/r/126213/diff/ > > > Testing > ------- > > > Thanks, > > Raphael Cojocaru > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
