----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126310/#review90498 -----------------------------------------------------------
Ship it! Looks good, please commit. Please also cherry-pick it to master (but do not merge the branch to master). We also have a Marble project at phabricator btw and use that for review requests now instead of reviewboard, see https://phabricator.kde.org/ - Dennis Nienhüser On Dec. 10, 2015, 9:51 p.m., Sandro Knauß wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126310/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 9:51 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > error: conversion from 'QHash<int, QPair<double, double> >::iterator' to > non-scalar type 'QHash<int, QPair<double, double> >::const_iterator' requested > > > Diffs > ----- > > tools/constellations2kml/constellations2kml.cpp > 5ab97ec3bd9a5f0e41a0e35a1c21039102d87cf2 > tools/mapreproject/OsmTileClusterRenderer.cpp > 53c994cb404bfa10a53f47d85b97b4305d0501f4 > > Diff: https://git.reviewboard.kde.org/r/126310/diff/ > > > Testing > ------- > > before: doesn't build > after: it builds :D > > > Thanks, > > Sandro Knauß > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
